Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 566403002: Optimize View::UpdateRootBounds (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
luken
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Optimize View::UpdateRootBounds If a view has a ton of children (say > 5000) with the majority hidden then we spend a lot of unecessary time in View::UpdateRootBounds on every paint. BUG=409126 TEST=none, see bug R=luken@chromium.org Committed: https://crrev.com/d173d9821f7823e2edb477a08bd3fa9f742ea9dc Cr-Commit-Position: refs/heads/master@{#294878}

Patch Set 1 #

Total comments: 1

Patch Set 2 : boundstree #

Patch Set 3 : remove extra changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M ui/views/view.cc View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
sky
6 years, 3 months ago (2014-09-15 17:57:25 UTC) #1
tfarina
https://codereview.chromium.org/566403002/diff/1/ui/views/view.cc File ui/views/view.cc (right): https://codereview.chromium.org/566403002/diff/1/ui/views/view.cc#newcode423 ui/views/view.cc:423: // We're never painted when hidden, so no need ...
6 years, 3 months ago (2014-09-15 18:02:09 UTC) #2
sky
Done
6 years, 3 months ago (2014-09-15 18:07:51 UTC) #3
luken
lgtm
6 years, 3 months ago (2014-09-15 18:59:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566403002/40001
6 years, 3 months ago (2014-09-15 19:16:43 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 4eac4add1d840079d26aa61f6e2ff5e55fc6c2ca
6 years, 3 months ago (2014-09-15 20:20:40 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 20:23:16 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d173d9821f7823e2edb477a08bd3fa9f742ea9dc
Cr-Commit-Position: refs/heads/master@{#294878}

Powered by Google App Engine
This is Rietveld 408576698