Nested picture nanobench

Nested picture nanobench

Measure picture overhead for recording & playback using a Sierpinski fractal (http://skfiddle.com/c/a2b6e60d775543b7c29a5d45d0371c02) with various picture nesting levels.

Committed: https://skia.googlesource.com/skia/+/44162675ca4b790c2af0fbd9c41f262c8be26b05

[f(malita), 2014-09-15 20:10:00]

fmalita@chromium.org changed reviewers:
+ mtklein@google.com

[f(malita), 2014-09-15 20:15:35]

fmalita@chromium.org changed reviewers:
+ reed@google.com

[f(malita), 2014-09-15 20:22:57]

On 2014/09/15 20:15:45, Florin Malita wrote:

Current numbers on my workstation:

 
39M	1	6.09ms	6.13ms	6.13ms	6.17ms	0%	█▃▄▂▇▁▇▄▂▄	8888	picture_nesting_playback_3280
 
39M	1	5.55ms	5.56ms	5.56ms	5.58ms	0%	▃▄▅█▁▃▁█▃▁	8888	picture_nesting_playback_1093
 
39M	1	5.16ms	5.18ms	5.18ms	5.24ms	1%	▁▁▄█▁▂▅▁▃▄	8888	picture_nesting_playback_364
 
39M	1	5.05ms	5.08ms	5.07ms	5.09ms	0%	▄█▁▅▇▃▃▆▆▅	8888	picture_nesting_playback_121
 
39M	1	5.02ms	5.04ms	5.04ms	5.06ms	0%	▃█▁▅▅▂▅▅▃█	8888	picture_nesting_playback_40
 
39M	1	3.86ms	5.01ms	4.75ms	5.04ms	10%	███████▅▁▁	8888	picture_nesting_playback_13
 
39M	1	3.81ms	3.88ms	3.87ms	3.92ms	1%	▃█▄▅▅▁▅▃▅▅	8888	picture_nesting_playback_4
 
39M	1	3.82ms	3.86ms	3.87ms	3.98ms	1%	▂▁▃▂▄▂▃█▃▃	8888	picture_nesting_playback_1
 
39M	1	3.79ms	3.82ms	3.82ms	3.91ms	1%	█▂▃▃▃▁▁▂▃▃	8888	picture_nesting_playback_0
 
39M	1	6.09ms	6.21ms	6.19ms	6.29ms	1%	█▅▇▁▄▆▂█▄▁	8888	picture_nesting_recording_3280
 
39M	1	3.26ms	3.28ms	3.28ms	3.31ms	0%	▄▂▂▁▂▆▃▄█▄	8888	picture_nesting_recording_1093
 
39M	1	2.19ms	2.23ms	2.33ms	2.8ms	9%	▁▁▁▁▁▁▂█▅▄	8888	picture_nesting_recording_364
 
39M	1	2ms	2.02ms	2.03ms	2.08ms	1%	▁█▃▃▁▅▁▂▁▃	8888	picture_nesting_recording_121
 
39M	1	1.71ms	1.76ms	1.76ms	1.84ms	3%	▇█▇▄▄▃▂▁▁▁	8888	picture_nesting_recording_40
 
39M	1	1.62ms	1.64ms	1.64ms	1.7ms	2%	▃▁▂▄▃▄▁▃▁█	8888	picture_nesting_recording_13
 
39M	1	1.6ms	1.61ms	1.61ms	1.66ms	1%	▂▁▅█▂▂▁▃▂▅	8888	picture_nesting_recording_4
 
39M	1	1.55ms	1.58ms	1.57ms	1.61ms	1%	▅▁▅▄▄▃▂█▄▄	8888	picture_nesting_recording_1
 
39M	1	1.57ms	1.58ms	1.58ms	1.61ms	1%	▁█▁▂▅▆▃▁▄▁	8888	picture_nesting_recording_0

[mtklein, 2014-09-15 20:38:39]

https://codereview.chromium.org/566393002/diff/60001/bench/PictureNestingBenc...
File bench/PictureNestingBench.cpp (right):

https://codereview.chromium.org/566393002/diff/60001/bench/PictureNestingBenc...
bench/PictureNestingBench.cpp:17: static int spinsky(SkCanvas* canvas, int lvl,
const SkPaint& paint, int maxLevel,
lvl, maxLevel...

and maybe consider spelling it sierpinski?

[f(malita), 2014-09-15 22:09:26]

https://codereview.chromium.org/566393002/diff/60001/bench/PictureNestingBenc...
File bench/PictureNestingBench.cpp (right):

https://codereview.chromium.org/566393002/diff/60001/bench/PictureNestingBenc...
bench/PictureNestingBench.cpp:17: static int spinsky(SkCanvas* canvas, int lvl,
const SkPaint& paint, int maxLevel,
On 2014/09/15 20:38:39, mtklein wrote:
> lvl, maxLevel...

Converted to a protected method & dropped the max params completely.

> and maybe consider spelling it sierpinski?

Done.

[mtklein, 2014-09-15 22:14:20]

lgtm

[f(malita), 2014-09-15 23:39:15]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-09-15 23:39:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566393002/80001

[commit-bot: I haz the power, 2014-09-15 23:46:22]

Committed patchset #5 (id:80001) as 44162675ca4b790c2af0fbd9c41f262c8be26b05