Source/core/svg/SVGFontFaceUriElement.cpp - Issue 566373002: Use ConstructFromLiteral instead of implicit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGFontFaceUriElement.cpp

Issue 566373002: Use ConstructFromLiteral instead of implicit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Two more fixes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGFontFaceUriElement.cpp

diff --git a/Source/core/svg/SVGFontFaceUriElement.cpp b/Source/core/svg/SVGFontFaceUriElement.cpp

index eac4fd8d3459644626e2840326580cf0a326306b..6d91b99bd6c5a8767f4297f03cfbd842835766a6 100644

--- a/Source/core/svg/SVGFontFaceUriElement.cpp

+++ b/Source/core/svg/SVGFontFaceUriElement.cpp

@@ -51,7 +51,7 @@ PassRefPtrWillBeRawPtr<CSSFontFaceSrcValue> SVGFontFaceUriElement::srcValue() co

{

RefPtrWillBeRawPtr<CSSFontFaceSrcValue> src = CSSFontFaceSrcValue::create(getAttribute(XLinkNames::hrefAttr));

AtomicString value(fastGetAttribute(formatAttr));

- src->setFormat(value.isEmpty() ? "svg" : value); // Default format

+ src->setFormat(value.isEmpty() ? AtomicString("svg", AtomicString::ConstructFromLiteral) : value); // Default format

return src.release();

}

« no previous file with comments | « Source/core/svg/SVGAnimatedAngle.cpp ('k') | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »