Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 566373002: Use ConstructFromLiteral instead of implicit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Two more fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGFontFaceUriElement.cpp ('k') | Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 }; 73 };
74 74
75 inline RepeatEvent* toRepeatEvent(Event* event) 75 inline RepeatEvent* toRepeatEvent(Event* event)
76 { 76 {
77 ASSERT_WITH_SECURITY_IMPLICATION(!event || event->type() == "repeatn"); 77 ASSERT_WITH_SECURITY_IMPLICATION(!event || event->type() == "repeatn");
78 return static_cast<RepeatEvent*>(event); 78 return static_cast<RepeatEvent*>(event);
79 } 79 }
80 80
81 static SMILEventSender& smilEndEventSender() 81 static SMILEventSender& smilEndEventSender()
82 { 82 {
83 DEFINE_STATIC_LOCAL(SMILEventSender, sender, ("endEvent")); 83 DEFINE_STATIC_LOCAL(SMILEventSender, sender, (EventTypeNames::endEvent));
84 return sender; 84 return sender;
85 } 85 }
86 86
87 static SMILEventSender& smilBeginEventSender() 87 static SMILEventSender& smilBeginEventSender()
88 { 88 {
89 DEFINE_STATIC_LOCAL(SMILEventSender, sender, ("beginEvent")); 89 DEFINE_STATIC_LOCAL(SMILEventSender, sender, (EventTypeNames::beginEvent));
90 return sender; 90 return sender;
91 } 91 }
92 92
93 static SMILEventSender& smilRepeatEventSender() 93 static SMILEventSender& smilRepeatEventSender()
94 { 94 {
95 DEFINE_STATIC_LOCAL(SMILEventSender, sender, ("repeatEvent")); 95 DEFINE_STATIC_LOCAL(SMILEventSender, sender, (EventTypeNames::repeatEvent));
96 return sender; 96 return sender;
97 } 97 }
98 98
99 static SMILEventSender& smilRepeatNEventSender() 99 static SMILEventSender& smilRepeatNEventSender()
100 { 100 {
101 DEFINE_STATIC_LOCAL(SMILEventSender, sender, ("repeatn")); 101 DEFINE_STATIC_LOCAL(SMILEventSender, sender, (AtomicString("repeatn", Atomic String::ConstructFromLiteral)));
102 return sender; 102 return sender;
103 } 103 }
104 104
105 // This is used for duration type time values that can't be negative. 105 // This is used for duration type time values that can't be negative.
106 static const double invalidCachedTime = -1.; 106 static const double invalidCachedTime = -1.;
107 107
108 class ConditionEventListener FINAL : public EventListener { 108 class ConditionEventListener FINAL : public EventListener {
109 public: 109 public:
110 static PassRefPtr<ConditionEventListener> create(SVGSMILElement* animation, SVGSMILElement::Condition* condition) 110 static PassRefPtr<ConditionEventListener> create(SVGSMILElement* animation, SVGSMILElement::Condition* condition)
111 { 111 {
(...skipping 1250 matching lines...) Expand 10 before | Expand all | Expand 10 after
1362 #if ENABLE(OILPAN) 1362 #if ENABLE(OILPAN)
1363 visitor->trace(m_targetElement); 1363 visitor->trace(m_targetElement);
1364 visitor->trace(m_timeContainer); 1364 visitor->trace(m_timeContainer);
1365 visitor->trace(m_conditions); 1365 visitor->trace(m_conditions);
1366 visitor->trace(m_syncBaseDependents); 1366 visitor->trace(m_syncBaseDependents);
1367 #endif 1367 #endif
1368 SVGElement::trace(visitor); 1368 SVGElement::trace(visitor);
1369 } 1369 }
1370 1370
1371 } 1371 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGFontFaceUriElement.cpp ('k') | Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698