Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: Source/core/svg/SVGAnimatedAngle.cpp

Issue 566373002: Use ConstructFromLiteral instead of implicit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Two more fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/shadow/MediaControls.cpp ('k') | Source/core/svg/SVGFontFaceUriElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 , m_orientType(SVGAnimatedEnumeration<SVGMarkerOrientType>::create(contextEl ement, SVGNames::orientAttr, baseValue()->orientType())) 42 , m_orientType(SVGAnimatedEnumeration<SVGMarkerOrientType>::create(contextEl ement, SVGNames::orientAttr, baseValue()->orientType()))
43 { 43 {
44 } 44 }
45 45
46 SVGAnimatedAngle::~SVGAnimatedAngle() 46 SVGAnimatedAngle::~SVGAnimatedAngle()
47 { 47 {
48 } 48 }
49 49
50 void SVGAnimatedAngle::synchronizeAttribute() 50 void SVGAnimatedAngle::synchronizeAttribute()
51 { 51 {
52 DEFINE_STATIC_LOCAL(const AtomicString, autoValue, ("auto", AtomicString::Co nstructFromLiteral));
52 AtomicString value; 53 AtomicString value;
53 if (m_orientType->currentValue()->enumValue() == SVGMarkerOrientAuto) 54 if (m_orientType->currentValue()->enumValue() == SVGMarkerOrientAuto)
54 value = "auto"; 55 value = autoValue;
55 else 56 else
56 value = AtomicString(currentValue()->valueAsString()); 57 value = AtomicString(currentValue()->valueAsString());
57 58
58 contextElement()->setSynchronizedLazyAttribute(attributeName(), value); 59 contextElement()->setSynchronizedLazyAttribute(attributeName(), value);
59 } 60 }
60 61
61 void SVGAnimatedAngle::setAnimatedValue(PassRefPtr<SVGPropertyBase> value) 62 void SVGAnimatedAngle::setAnimatedValue(PassRefPtr<SVGPropertyBase> value)
62 { 63 {
63 SVGAnimatedProperty<SVGAngle>::setAnimatedValue(value); 64 SVGAnimatedProperty<SVGAngle>::setAnimatedValue(value);
64 m_orientType->setAnimatedValue(currentValue()->orientType()); 65 m_orientType->setAnimatedValue(currentValue()->orientType());
65 } 66 }
66 67
67 void SVGAnimatedAngle::animationEnded() 68 void SVGAnimatedAngle::animationEnded()
68 { 69 {
69 SVGAnimatedProperty<SVGAngle>::animationEnded(); 70 SVGAnimatedProperty<SVGAngle>::animationEnded();
70 m_orientType->animationEnded(); 71 m_orientType->animationEnded();
71 } 72 }
72 73
73 } 74 }
OLDNEW
« no previous file with comments | « Source/core/html/shadow/MediaControls.cpp ('k') | Source/core/svg/SVGFontFaceUriElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698