build/vs_toolchain.py - Issue 566343002: gn: Make WDK_DIR environment variable optional for VS professional users

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/vs_toolchain.py

Issue 566343002: gn: Make WDK_DIR environment variable optional for VS professional users (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use os.environ.get instead Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/vs_toolchain.py

diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py

index 735827e94316f4125b42d41ed389719955050612..44c30171377d3045721b928faa3db6d0f55588a7 100644

--- a/build/vs_toolchain.py

+++ b/build/vs_toolchain.py

@@ -172,7 +172,7 @@ wdk_dir = "%s"

os.environ['GYP_MSVS_OVERRIDE_PATH'],

os.environ['WINDOWSSDKDIR'],

os.environ['GYP_MSVS_VERSION'],

- os.environ['WDK_DIR'])

+ os.environ.get('WDK_DIR', ''))

def main():

« no previous file with comments | « no previous file | no next file » | no next file with comments »