Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 566333002: mojo: Update gyp python targets to specify their equivalent gn targets. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Update gyp python targets to specify their equivalent gn targets. R=jamesr@chromium.org Committed: https://crrev.com/8a1856330b56cc79584a9b7848a2ef83ba8fe3af Cr-Commit-Position: refs/heads/master@{#295036}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M mojo/mojo.gyp View 4 chunks +4 lines, -0 lines 0 comments Download
M mojo/public/python/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/python/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
qsr
6 years, 3 months ago (2014-09-15 12:27:42 UTC) #1
jamesr
lgtm https://codereview.chromium.org/566333002/diff/1/mojo/python/BUILD.gn File mojo/python/BUILD.gn (right): https://codereview.chromium.org/566333002/diff/1/mojo/python/BUILD.gn#newcode9 mojo/python/BUILD.gn:9: "//mojo/public/python", order should be local targets first (sorted, ...
6 years, 3 months ago (2014-09-15 17:18:06 UTC) #2
qsr
https://codereview.chromium.org/566333002/diff/1/mojo/python/BUILD.gn File mojo/python/BUILD.gn (right): https://codereview.chromium.org/566333002/diff/1/mojo/python/BUILD.gn#newcode9 mojo/python/BUILD.gn:9: "//mojo/public/python", On 2014/09/15 17:18:05, jamesr wrote: > order should ...
6 years, 3 months ago (2014-09-16 08:46:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566333002/20001
6 years, 3 months ago (2014-09-16 08:47:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3d68d26ac7d08ee8721e812ffdd463805d5420dc
6 years, 3 months ago (2014-09-16 09:43:33 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 09:45:09 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a1856330b56cc79584a9b7848a2ef83ba8fe3af
Cr-Commit-Position: refs/heads/master@{#295036}

Powered by Google App Engine
This is Rietveld 408576698