Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 566303003: Disable lowering to StringAdd due to various issues. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Disable lowering to StringAdd due to various issues. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-357052.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/string-oom-concat.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-15 12:27:32 UTC) #1
titzer
On 2014/09/15 12:27:32, Michael Starzinger wrote: lgtm
6 years, 3 months ago (2014-09-16 07:57:25 UTC) #2
Michael Starzinger
6 years, 3 months ago (2014-09-16 08:30:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698