Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 566303002: Synchronize GN version of gfx_unittests target with the GYP one. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Synchronize GN version of gfx_unittests target with the GYP one. BUG=None TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug gfx_unittests R=brettw@chromium.org,sky@chromium.org Committed: https://crrev.com/acf4b077263aff159d9b7cd787582002ae5b746f Cr-Commit-Position: refs/heads/master@{#295229}

Patch Set 1 #

Patch Set 2 : fix linux_chromium_gn_rel trybot? not sure about android one #

Patch Set 3 : rm image_unittest_util* for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -14 lines) Patch
M ui/gfx/BUILD.gn View 1 2 2 chunks +121 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
tfarina
6 years, 3 months ago (2014-09-15 02:11:56 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-15 02:24:14 UTC) #2
tfarina
Brett, how come image_unittest_util is being compiled on both test_support and gfx_unittests if it is ...
6 years, 3 months ago (2014-09-15 12:18:47 UTC) #3
tfarina
Brett, the error looks like this: /mnt/scratch0/b_used/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld.gold: error: obj/ui/gfx/image/test_support.image_unittest_util.o: multiple definition of 'gfx::test::CreateBitmap(int, int)' /mnt/scratch0/b_used/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.9/../../../../arm-linux-androideabi/bin/ld.gold: ...
6 years, 3 months ago (2014-09-15 17:59:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566303002/20001
6 years, 3 months ago (2014-09-15 19:16:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11041)
6 years, 3 months ago (2014-09-15 20:10:50 UTC) #8
tfarina
Ping. Scott, I need your approval for ui/.
6 years, 3 months ago (2014-09-15 21:40:27 UTC) #9
sky
LGTM
6 years, 3 months ago (2014-09-15 22:26:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566303002/40001
6 years, 3 months ago (2014-09-17 03:37:24 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as aa8913e239b693307c60e78fb4219667f8610c0e
6 years, 3 months ago (2014-09-17 04:34:26 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 04:35:07 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/acf4b077263aff159d9b7cd787582002ae5b746f
Cr-Commit-Position: refs/heads/master@{#295229}

Powered by Google App Engine
This is Rietveld 408576698