Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 566253005: Clean up all the ScriptedAnimationController logging. (Closed)

Created:
6 years, 3 months ago by Zhenyao Mo
Modified:
6 years, 3 months ago
CC:
blink-reviews, shans, rjwright, dstockwell, blink-reviews-animation_chromium.org, sof, eae+blinkwatch, Timothy Loh, Mike Lawther (Google), blink-reviews-dom_chromium.org, dglazkov+blink, Steve Block, darktears, mkwst+moarreviews_chromium.org, Eric Willigers, rwlbuis
Project:
blink
Visibility:
Public.

Description

Clean up all the ScriptedAnimationController logging. We already figured out the cause of the flakiness. These loggings are no longer needed. BUG=393331 TEST=bots TBR=kbr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.cpp View 7 chunks +0 lines, -17 lines 0 comments Download
M Source/core/page/PageAnimator.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566253005/1
6 years, 3 months ago (2014-09-15 19:40:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 182006
6 years, 3 months ago (2014-09-15 21:06:18 UTC) #3
Ken Russell (switch to Gerrit)
LGTM, though I wonder if we should have just turned off the logging in the ...
6 years, 3 months ago (2014-09-16 01:06:11 UTC) #4
Zhenyao Mo
On 2014/09/16 01:06:11, Ken Russell wrote: > LGTM, though I wonder if we should have ...
6 years, 3 months ago (2014-09-16 01:09:43 UTC) #5
Ken Russell (switch to Gerrit)
6 years, 3 months ago (2014-09-16 01:17:33 UTC) #6
Message was sent while issue was closed.
On 2014/09/16 01:09:43, Zhenyao Mo wrote:
> On 2014/09/16 01:06:11, Ken Russell wrote:
> > LGTM, though I wonder if we should have just turned off the logging in the
GPU
> > recipe for the next time an issue in this area crops up. (Not sure whether
> these
> > logs had any run-time cost in Release builds -- can't imagine they would.)
> 
> We can always revert this CL.  They are so ugly, it hurts my stomach to see
them
> sit there one sec longer.

All good. :)

Powered by Google App Engine
This is Rietveld 408576698