Cast: Allow extension to control wifi options on windows

net/base/net_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/net_util.h"
 
 #include <string.h>
 
 #include <ostream>
 
@@ skipping 772 matching lines @@
       EXPECT_NE(WIFI_PHY_LAYER_PROTOCOL_NONE, GetWifiPHYLayerProtocol());
     }
 #elif !defined(OS_ANDROID)
     char name[IF_NAMESIZE];
     EXPECT_TRUE(if_indextoname(it->interface_index, name));
     EXPECT_STREQ(it->name.c_str(), name);
 #endif
   }
 }
 
+// Test SetWifiOptions().
+TEST(NetUtilTest, SetWifiOptionsTest) {
+  SetWifiOptions(0);
+  SetWifiOptions(WIFI_OPTIONS_DISABLE_SCAN);
+  SetWifiOptions(WIFI_OPTIONS_MEDIA_STREAMING_MODE);
+  SetWifiOptions(WIFI_OPTIONS_DISABLE_SCAN |
+                 WIFI_OPTIONS_MEDIA_STREAMING_MODE);

[pauljensen, 2014/09/18 14:16:50]

I assume you can verify that these functions are taking effect and cleaning up
after themselves with WlanQueryInterface.  Can you please add that verification
here?

[hubbe, 2014/09/18 18:21:05]

It's possible, but is it worth it?

I'll have to expose WlanQueryInterface from inside net_util_win.h, or duplicate
the code here, and then it will only ever do something if the computer you run
the test on actually has a wifi interface.
(Which I don't think any of our test bots have.)

AND, to top it all off, it's possible to configure your window ACLs such that
calling SetWifiOptions always fails unless you're administrator.... (Although
I'm not sure if anybody anywhere actually does that.)

If you still think it's worth it, do you prefer that I expose the wlanapi, or
duplicate the code?

[pauljensen, 2014/09/18 18:40:20]

I believe it is worth adding a test when adding a new API and implementation. 
If there is value in adding the functionality, there is value in ensuring that
functionality works now and continues to work.  It's unfortunate that most/all
of our bots don't have Wifi; which begs the question, how is the Cast extension
tested?  i.e. how will you know this new API works?

Exposing the wlanapi just to tests seems fine.

[hubbe, 2014/09/18 23:42:51]

Done.

+}
+
+
 struct NonUniqueNameTestData {
   bool is_unique;
   const char* hostname;
 };
 
 // Google Test pretty-printer.
 void PrintTo(const NonUniqueNameTestData& data, std::ostream* os) {
   ASSERT_TRUE(data.hostname);
   *os << " hostname: " << testing::PrintToString(data.hostname)
       << "; is_unique: " << testing::PrintToString(data.is_unique);
@@ skipping 61 matching lines @@
 TEST_P(NetUtilNonUniqueNameTest, IsHostnameNonUnique) {
   const NonUniqueNameTestData& test_data = GetParam();
 
   EXPECT_EQ(test_data.is_unique, IsUnique(test_data.hostname));
 }
 
 INSTANTIATE_TEST_CASE_P(, NetUtilNonUniqueNameTest,
                         testing::ValuesIn(kNonUniqueNameTestData));
 
 }  // namespace net