Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 566233004: Fix a DCHECK fired when switching between screen capturing and windown capturing. (Closed)

Created:
6 years, 3 months ago by jiayl
Modified:
6 years, 3 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a DCHECK fired when switching between screen capturing and windown capturing. BUG=414433 Committed: https://crrev.com/8d53e0c73c52b443fb9c1ad27a898ddb2cad979f Cr-Commit-Position: refs/heads/master@{#295078}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M content/browser/media/capture/desktop_capture_device.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jiayl
PTAL
6 years, 3 months ago (2014-09-15 23:29:00 UTC) #3
Sergey Ulanov
lgtm
6 years, 3 months ago (2014-09-16 00:23:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566233004/20001
6 years, 3 months ago (2014-09-16 15:21:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 73422c90eeac71b38a1ffcbc57c4190f81cc1e40
6 years, 3 months ago (2014-09-16 16:16:46 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 16:19:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d53e0c73c52b443fb9c1ad27a898ddb2cad979f
Cr-Commit-Position: refs/heads/master@{#295078}

Powered by Google App Engine
This is Rietveld 408576698