Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1630)

Unified Diff: chrome/browser/policy/policy_loader_mac.h

Issue 56623005: Policy providers all get a SchemaRegistry to work with. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chrome-policy-schema-9-purge-with-callback
Patch Set: Fixed mac tests Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/policy_loader_mac.h
diff --git a/chrome/browser/policy/policy_loader_mac.h b/chrome/browser/policy/policy_loader_mac.h
index 68da9e4142c4574acd29d24b7193711f7c7f045d..90a7b2b01081c1881a27160d39db43a966305ab6 100644
--- a/chrome/browser/policy/policy_loader_mac.h
+++ b/chrome/browser/policy/policy_loader_mac.h
@@ -23,7 +23,6 @@ class Value;
namespace policy {
-class PolicyDomainDescriptor;
class PolicyMap;
class Schema;
struct PolicyDefinitionList;
@@ -53,17 +52,17 @@ class PolicyLoaderMac : public AsyncPolicyLoader {
// Callback for the FilePathWatcher.
void OnFileUpdated(const base::FilePath& path, bool error);
- // Loads policies for the components described in |descriptor|, which belong
- // to the domain |domain_name|, and stores them in the |bundle|.
+ // Loads policies for the components described in the current SchemaMap,
bartfab (slow) 2013/11/05 15:53:04 Nit 1: s/SchemaMap/schema_map_/ (reference the mem
Joao da Silva 2013/11/07 13:15:00 Done.
+ // which belong to the domain |domain_name|, and stores them in the |bundle|.
void LoadPolicyForDomain(
- scoped_refptr<const PolicyDomainDescriptor> descriptor,
+ PolicyDomain domain,
bartfab (slow) 2013/11/05 15:53:04 Nit: #include "components/policy/core/common/polic
Joao da Silva 2013/11/07 13:15:00 Done.
const std::string& domain_name,
PolicyBundle* bundle);
bartfab (slow) 2013/11/05 15:53:04 Nit: Forward-declare PolicyBundle.
Joao da Silva 2013/11/07 13:15:00 Done.
// Loads the policies described in |schema| from the bundle identified by
// |bundle_id_string|, and stores them in |policy|.
void LoadPolicyForComponent(const std::string& bundle_id_string,
- Schema schema,
+ const Schema& schema,
PolicyMap* policy);
// List of recognized policies.

Powered by Google App Engine
This is Rietveld 408576698