chrome/browser/policy/async_policy_provider_unittest.cc - Issue 56623005: Policy providers all get a SchemaRegistry to work with.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/async_policy_provider_unittest.cc

Issue 56623005: Policy providers all get a SchemaRegistry to work with. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chrome-policy-schema-9-purge-with-callback

Patch Set: Fixed mac tests Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/policy/async_policy_provider.h ('K') | « chrome/browser/policy/async_policy_provider.cc ('k') | chrome/browser/policy/browser_policy_connector.h » ('j') | chrome/browser/policy/cloud/cloud_policy_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/async_policy_provider_unittest.cc

diff --git a/chrome/browser/policy/async_policy_provider_unittest.cc b/chrome/browser/policy/async_policy_provider_unittest.cc

index 677dba84d3756f5b7d563604baeca3c999b85cdd..ffe756ce3b0b1358a67aea31f863d35bb2f48eef 100644

--- a/chrome/browser/policy/async_policy_provider_unittest.cc

+++ b/chrome/browser/policy/async_policy_provider_unittest.cc

@@ -84,6 +84,7 @@ class AsyncPolicyProviderTest : public testing::Test {

virtual void TearDown() OVERRIDE;

base::MessageLoop loop_;

+ SchemaRegistry schema_registry_;

bartfab (slow) 2013/11/05 15:53:04 Nit: #include "chrome/browser/policy/schema_regist

Joao da Silva 2013/11/07 13:15:00 Done.

PolicyBundle initial_bundle_;

MockPolicyLoader* loader_;

scoped_ptr<AsyncPolicyProvider> provider_;

@@ -104,9 +105,9 @@ void AsyncPolicyProviderTest::SetUp() {

EXPECT_CALL(*loader_, InitOnBackgroundThread()).Times(1);

EXPECT_CALL(*loader_, MockLoad()).WillOnce(Return(&initial_bundle_));

- provider_.reset(

- new AsyncPolicyProvider(scoped_ptr<AsyncPolicyLoader>(loader_)));

- provider_->Init();

+ provider_.reset(new AsyncPolicyProvider(

+ &schema_registry_, scoped_ptr<AsyncPolicyLoader>(loader_)));

+ provider_->Init(&schema_registry_);

// Verify that the initial load is done synchronously:

EXPECT_TRUE(provider_->policies().Equals(initial_bundle_));