Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 56623003: Do not clobber the packaged app's default opacity (Closed)

Created:
7 years, 1 month ago by pkotwicz
Modified:
7 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

ChromeOS windows are transparent by default. This allows the window header to be transparent when there is only one window on screen. This CL fixes a case where we were clobbering the window's default opacity. BUG=312441 TEST=See bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/ui/views/apps/native_app_window_views.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pkotwicz
benwells@ can you please take a look?
7 years, 1 month ago (2013-11-02 00:52:14 UTC) #1
benwells
lgtm
7 years, 1 month ago (2013-11-04 00:51:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/56623003/1
7 years, 1 month ago (2013-11-04 06:33:08 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97099
7 years, 1 month ago (2013-11-04 08:55:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/56623003/1
7 years, 1 month ago (2013-11-04 16:13:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/56623003/1
7 years, 1 month ago (2013-11-04 17:49:07 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97402
7 years, 1 month ago (2013-11-04 23:22:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/56623003/1
7 years, 1 month ago (2013-11-05 00:25:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/56623003/1
7 years, 1 month ago (2013-11-05 03:20:40 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 04:14:08 UTC) #10
Message was sent while issue was closed.
Change committed as 232898

Powered by Google App Engine
This is Rietveld 408576698