Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 566133002: Cleanup: Reorganize extensions renderer build files so we only have to list each file once, rather … (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Reorganize extensions renderer build files so we only have to list each file once, rather than two if they are excluded on Android. Remove all native handlers from the Android build while we are at it. BUG=402728 Committed: https://crrev.com/ef39cfed7f2b2d450456eeeb8d049f26c8545bf7 Cr-Commit-Position: refs/heads/master@{#294887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -94 lines) Patch
M extensions/extensions.gyp View 5 chunks +34 lines, -47 lines 0 comments Download
M extensions/renderer/BUILD.gn View 5 chunks +34 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
The exclusion list does not scale.
6 years, 3 months ago (2014-09-13 02:32:16 UTC) #2
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-15 18:45:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566133002/1
6 years, 3 months ago (2014-09-15 19:16:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 15487f9177b1ff00e97646cc3f7e5889315ec826
6 years, 3 months ago (2014-09-15 20:49:46 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 20:53:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef39cfed7f2b2d450456eeeb8d049f26c8545bf7
Cr-Commit-Position: refs/heads/master@{#294887}

Powered by Google App Engine
This is Rietveld 408576698