Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: sdk/lib/_internal/pub/lib/src/validator/executable.dart

Issue 566093003: Create binstubs for executables when activating a package. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise! Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 library pub.validator.compiled_dartdoc;
nweiz 2014/09/18 21:51:49 One more thing: make this match the path.
Bob Nystrom 2014/09/18 22:23:48 Done.
6
7 import 'dart:async';
8
9 import 'package:path/path.dart' as p;
10
11 import '../entrypoint.dart';
12 import '../io.dart';
13 import '../utils.dart';
14 import '../validator.dart';
15
16 /// Validates that a package's pubspec doesn't contain executables that
17 /// reference non-existent scripts.
18 class ExecutableValidator extends Validator {
19 ExecutableValidator(Entrypoint entrypoint)
20 : super(entrypoint);
21
22 Future validate() async {
23 // TODO(rnystrom): This can print false positives since a script may be
24 // produced by a transformer. Do something better.
25 var binFiles = entrypoint.root.listFiles(beneath: "bin", recursive: false)
26 .map((path) => p.relative(path, from: entrypoint.root.dir))
27 .toList();
28
29 entrypoint.root.pubspec.executables.forEach((executable, script) {
30 var scriptPath = p.join("bin", "$script.dart");
31 if (binFiles.contains(scriptPath)) return;
32
33 warnings.add('Your pubspec.yaml lists an executable "$executable" that '
34 'points to a script "$scriptPath" that does not exist.');
35 });
36 }
37 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/validator.dart ('k') | sdk/lib/_internal/pub/lib/src/validator/name.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698