Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | |
| 2 // for details. All rights reserved. Use of this source code is governed by a | |
| 3 // BSD-style license that can be found in the LICENSE file. | |
| 4 | |
| 5 library pub.validator.compiled_dartdoc; | |
| 6 | |
| 7 import 'dart:async'; | |
| 8 | |
| 9 import 'package:path/path.dart' as p; | |
| 10 | |
| 11 import '../entrypoint.dart'; | |
| 12 import '../io.dart'; | |
| 13 import '../utils.dart'; | |
| 14 import '../validator.dart'; | |
| 15 | |
| 16 /// Validates that a package's pubspec doesn't contain executables that | |
| 17 /// reference non-existent scripts. | |
| 18 class ExecutableValidator extends Validator { | |
| 19 ExecutableValidator(Entrypoint entrypoint) | |
| 20 : super(entrypoint); | |
| 21 | |
| 22 Future validate() async { | |
| 23 // TODO(rnystrom): This can print false positives since a script may be | |
| 24 // produced by a transformer. Do something better. | |
| 25 var binFiles = entrypoint.root.listFiles(beneath: "bin", recursive: false) | |
| 26 .map((path) => p.relative(path, from: entrypoint.root.dir)) | |
| 27 .toList(); | |
| 28 | |
| 29 entrypoint.root.pubspec.executables.forEach((executable, script) { | |
| 30 if (!binFiles.contains("bin/$script.dart")) { | |
|
nweiz
2014/09/17 22:58:27
Use p.join here. Also maybe short-circuit rather t
Bob Nystrom
2014/09/18 19:17:53
Done.
| |
| 31 warnings.add('Your pubspec.yaml lists an executable "$executable" that ' | |
| 32 'points to a script "bin/$script.dart" that does not exist.'); | |
|
nweiz
2014/09/17 22:58:27
Use p.join here as well to give native-feeling pat
Bob Nystrom
2014/09/18 19:17:53
Done.
| |
| 33 } | |
| 34 }); | |
| 35 } | |
| 36 } | |
| OLD | NEW |