Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 566093002: Remove NotificationDelegate::process_id(). (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 3 months ago
Reviewers:
dewittj
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove NotificationDelegate::process_id(). This field is not used at all. BUG=408755 R=dewittj@chromium.org TEST=build all succeeds Committed: https://crrev.com/a1071da8fb1ee450d651b9a1ef8d506f71f1b4dd Cr-Commit-Position: refs/heads/master@{#295130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -47 lines) Patch
M chrome/browser/extensions/api/notifications/notifications_api.cc View 3 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/notifications/notification.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notification_delegate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/notification_object_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_object_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Jun Mukai
6 years, 3 months ago (2014-09-13 00:13:30 UTC) #1
Jun Mukai
ping?
6 years, 3 months ago (2014-09-16 18:12:33 UTC) #2
dewittj
lgtm, thanks for doing some dirty cleanup work
6 years, 3 months ago (2014-09-16 18:14:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566093002/1
6 years, 3 months ago (2014-09-16 18:17:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3f79d69ed833f3308dc63dde1cd1fb7b4b6924a6
6 years, 3 months ago (2014-09-16 19:48:06 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 19:48:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1071da8fb1ee450d651b9a1ef8d506f71f1b4dd
Cr-Commit-Position: refs/heads/master@{#295130}

Powered by Google App Engine
This is Rietveld 408576698