Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 566083002: Linux sandbox: restrict clock_gettime() and clock_getres() (Closed)

Created:
6 years, 3 months ago by jln (very slow on Chromium)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Linux sandbox: restrict clock_gettime() and clock_getres() In the baseline policy, we restrict the |clk_id| parameter allowed in clock_gettime(). This applies to all sandboxed process types. In the renderer policy, we similarly restrict the |clk_id| parameter for clock_getres(). BUG=413469, 413855 Committed: https://crrev.com/3f43ba638732da04c922605827ad3e7e603d41e0 Cr-Commit-Position: refs/heads/master@{#294751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M content/common/sandbox_linux/bpf_renderer_policy_linux.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jln (very slow on Chromium)
Matthew: PTAL! bmeurer: mostly FYI. It doesn't seem like V8 is using any fancy clock ...
6 years, 3 months ago (2014-09-12 23:32:26 UTC) #2
mdempsky
lgtm
6 years, 3 months ago (2014-09-13 01:05:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566083002/1
6 years, 3 months ago (2014-09-13 17:15:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c9d37c1bb79271e170a49d0ac236aba7eb00a693
6 years, 3 months ago (2014-09-13 20:40:56 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 20:44:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f43ba638732da04c922605827ad3e7e603d41e0
Cr-Commit-Position: refs/heads/master@{#294751}

Powered by Google App Engine
This is Rietveld 408576698