Chromium Code Reviews

Issue 566073003: Fix a bug in ICU's bidi handling. (Closed)

Created:
6 years, 3 months ago by jungshik at Google
Modified:
6 years, 3 months ago
Reviewers:
ckocagil
CC:
chromium-reviews, inferno
Project:
chromium_deps
Visibility:
Public.

Description

Fix a bug in ICU's bidi handling. Cherry-pick an upstream patch from http://bugs.icu-project.org/trac/ticket/11054 BUG=402297 TEST=See the comment 7 and comment 27 in the bug (after rolling DEPS with this CL). R=ckocagil@chromium.org TBR=ckocagil@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=292003

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Stats (+156 lines, -32 lines)
M README.chromium View 12 chunks +31 lines, -27 lines 0 comments
A patches/bidi.patch View 1 chunk +95 lines, -0 lines 0 comments
M source/common/ubidi.c View 3 chunks +4 lines, -4 lines 0 comments
M source/common/ubidiimp.h View 1 chunk +1 line, -1 line 0 comments
M source/test/cintltst/cbiditst.c View 3 chunks +25 lines, -0 lines 0 comments

Messages

Total messages: 4 (1 generated)
jungshik at Google
6 years, 3 months ago (2014-09-17 17:20:10 UTC) #2
ckocagil
lgtm
6 years, 3 months ago (2014-09-17 17:21:44 UTC) #3
jungshik at Google
6 years, 3 months ago (2014-09-17 18:53:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r292003 (presubmit successful).

Powered by Google App Engine