Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2526)

Unified Diff: chrome/browser/resources/options/manage_profile_overlay.js

Issue 566063002: Compile chrome://settings, part 8: the final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_6
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/manage_profile_overlay.js
diff --git a/chrome/browser/resources/options/manage_profile_overlay.js b/chrome/browser/resources/options/manage_profile_overlay.js
index 04ff1ac0b01f8b807d93e413a8762754fe41ae04..6bf69f82750f1447465aeebeeac04d34fb2f45e3 100644
--- a/chrome/browser/resources/options/manage_profile_overlay.js
+++ b/chrome/browser/resources/options/manage_profile_overlay.js
@@ -418,7 +418,7 @@ cr.define('options', function() {
* @private
*/
onSigninError_: function() {
- this.updateSignedInStatus_(this.signedInEmail_, true);
+ this.updateSignedInStatus(this.signedInEmail_, true);
},
/**
@@ -461,8 +461,15 @@ cr.define('options', function() {
options.SupervisedUserListData.resetPromise();
},
- /** @private */
- updateSignedInStatus_: assertNotReached,
+ /**
+ * Abstract method. Should be overriden in subclasses.
+ * @param {string} email
+ * @param {boolean} hasError
+ * @protected
+ */
+ updateSignedInStatus: function(email, hasError) {
+ assertNotReached();
+ },
/**
* Called when the user clicks "OK" or hits enter. Creates the profile
@@ -769,6 +776,15 @@ cr.define('options', function() {
},
/**
+ * @param {string} email
+ * @param {boolean} hasError
+ * @override
+ */
+ updateSignedInStatus: function(email, hasError) {
+ this.updateSignedInStatus_(email, hasError);
+ },
+
+ /**
* Updates the signed-in or not-signed-in UI when in create mode. Called by
* the handler in response to the 'requestCreateProfileUpdate' message.
* updateSupervisedUsersAllowed_ is expected to be called after this is, and
« no previous file with comments | « chrome/browser/resources/options/handler_options_list.js ('k') | third_party/closure_compiler/compiled_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698