chrome/browser/resources/options/chromeos/internet_detail.js - Issue 566063002: Compile chrome://settings, part 8: the final battle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/internet_detail.js

Issue 566063002: Compile chrome://settings, part 8: the final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_6

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/chromeos/display_overscan.js ('k') | chrome/browser/resources/options/chromeos/onc_data.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/internet_detail.js

diff --git a/chrome/browser/resources/options/chromeos/internet_detail.js b/chrome/browser/resources/options/chromeos/internet_detail.js

index 58ccb093ef58c562f64f36f3bb73cae6e4c02c70..8d5b4537b1bde0ab187eb057f428710552480e49 100644

--- a/chrome/browser/resources/options/chromeos/internet_detail.js

+++ b/chrome/browser/resources/options/chromeos/internet_detail.js

@@ -1294,7 +1294,9 @@ cr.define('options.internet', function() {

}

var savedPrefix = onc.getActiveValue('SavedIPConfig.RoutingPrefix');

if (savedPrefix != undefined) {

- var savedNetmask = prefixLengthToNetmask(savedPrefix);

+ assert(typeof savedPrefix == 'number');

+ var savedNetmask = prefixLengthToNetmask(

+ /** @type {number} */(savedPrefix));

inetNetmask.automatic = savedNetmask;

inetNetmask.value = savedNetmask;

}

@@ -1320,7 +1322,9 @@ cr.define('options.internet', function() {

}

var staticPrefix = onc.getActiveValue('StaticIPConfig.RoutingPrefix');

if (staticPrefix != undefined) {

- var staticNetmask = prefixLengthToNetmask(staticPrefix);

+ assert(typeof staticPrefix == 'number');

+ var staticNetmask = prefixLengthToNetmask(

+ /** @type {number} */(staticPrefix));

inetNetmask.user = staticNetmask;

inetNetmask.value = staticNetmask;

}