Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 566063002: Compile chrome://settings, part 8: the final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_6
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 9a48d5df1071c25a599e1e37281abae23654ab2c..3205f0f8c33dd027ce44ffae0c136e729432a9e4 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -12,7 +12,6 @@ cr.exportPath('options');
* setupCompleted: (boolean|undefined),
* setupInProgress: (boolean|undefined),
* signedIn: (boolean|undefined),
- * signinAllowed: (boolean|undefined),
* signinAllowed: boolean,
* signoutAllowed: (boolean|undefined),
* statusText: (string|undefined),
@@ -21,6 +20,11 @@ cr.exportPath('options');
*/
options.SyncStatus;
+/**
+ * @typedef {{id: string, name: string}}
+ */
+options.ExtensionData;
+
cr.define('options', function() {
var OptionsPage = options.OptionsPage;
var Page = cr.ui.pageManager.Page;
@@ -1791,8 +1795,12 @@ cr.define('options', function() {
/**
* Toggles the warning boxes that show which extension is controlling
* various settings of Chrome.
- * @param {object} details A dictionary of ID+name pairs for each of the
- * settings controlled by an extension.
+ * @param {{searchEngine: options.ExtensionData,
+ * homePage: options.ExtensionData,
+ * startUpPage: options.ExtensionData,
+ * newTabPage: options.ExtensionData,
+ * proxy: options.ExtensionData}} details A dictionary of ID+name
+ * pairs for each of the settings controlled by an extension.
* @private
*/
toggleExtensionIndicators_: function(details) {
« no previous file with comments | « chrome/browser/resources/chromeos/user_images_grid.js ('k') | chrome/browser/resources/options/chromeos/display_overscan.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698