Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: chrome/browser/resources/options/handler_options_list.js

Issue 566063002: Compile chrome://settings, part 8: the final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_6
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
7 /** @const */ var List = cr.ui.List; 7 /** @const */ var List = cr.ui.List;
8 /** @const */ var ListItem = cr.ui.ListItem; 8 /** @const */ var ListItem = cr.ui.ListItem;
9 /** @const */ var DeletableItem = options.DeletableItem; 9 /** @const */ var DeletableItem = options.DeletableItem;
10 /** @const */ var DeletableItemList = options.DeletableItemList; 10 /** @const */ var DeletableItemList = options.DeletableItemList;
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 indicator.controlledBy = 'hasRecommendation'; 172 indicator.controlledBy = 'hasRecommendation';
173 indicator.resetHandler = function() { 173 indicator.resetHandler = function() {
174 // If there is a policy recommendation, data.handlers.length >= 1. 174 // If there is a policy recommendation, data.handlers.length >= 1.
175 // Setting the default handler to 0 ensures that it won't be 'none', 175 // Setting the default handler to 0 ensures that it won't be 'none',
176 // and there *is* a user registered handler created by setDefault, 176 // and there *is* a user registered handler created by setDefault,
177 // which is required for a change notification. 177 // which is required for a change notification.
178 // The user-registered handlers are removed in a loop. Note that if 178 // The user-registered handlers are removed in a loop. Note that if
179 // a handler is installed by policy, removeHandler does nothing. 179 // a handler is installed by policy, removeHandler does nothing.
180 delegate.setDefault(data.handlers[0]); 180 delegate.setDefault(data.handlers[0]);
181 for (var i = 0; i < data.handlers.length; ++i) { 181 for (var i = 0; i < data.handlers.length; ++i) {
182 delegate.removeHandler(value, data.handlers[i]); 182 delegate.removeHandler(i, data.handlers[i]);
183 } 183 }
184 }; 184 };
185 } else { 185 } else {
186 indicator.controlledBy = 'recommended'; 186 indicator.controlledBy = 'recommended';
187 } 187 }
188 this.appendChild(indicator); 188 this.appendChild(indicator);
189 } 189 }
190 190
191 if (data.registered_by_user) { 191 if (data.registered_by_user) {
192 // Remove link. 192 // Remove link.
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 }, 259 },
260 }; 260 };
261 261
262 return { 262 return {
263 IgnoredHandlersListItem: IgnoredHandlersListItem, 263 IgnoredHandlersListItem: IgnoredHandlersListItem,
264 IgnoredHandlersList: IgnoredHandlersList, 264 IgnoredHandlersList: IgnoredHandlersList,
265 HandlerListItem: HandlerListItem, 265 HandlerListItem: HandlerListItem,
266 HandlersList: HandlersList, 266 HandlersList: HandlersList,
267 }; 267 };
268 }); 268 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698