Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 56603002: Fixing comment constructor not functioning on IE (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 99e26883542b86f71750a319095dafeee754c79a..d1a106aeb0c8f17e7a747cbb9a68d55e8f1dc033 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -2071,19 +2071,14 @@ class CloseEvent extends Event native "CloseEvent" {
@DocsEditable()
@DomName('Comment')
class Comment extends CharacterData native "Comment" {
- // To suppress missing implicit constructor warnings.
- factory Comment._() { throw new UnsupportedError("Not supported"); }
-
- @DomName('Comment.Comment')
- @DocsEditable()
factory Comment([String data]) {
if (data != null) {
- return Comment._create_1(data);
+ return JS('Comment', '#.createComment(#)', document, data);
}
- return Comment._create_2();
+ return JS('Comment', '#.createComment("")', document);
}
- static Comment _create_1(data) => JS('Comment', 'new Comment(#)', data);
- static Comment _create_2() => JS('Comment', 'new Comment()');
+ // To suppress missing implicit constructor warnings.
+ factory Comment._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698