Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 566023004: cc: Stop using contents_scale_x() in PictureLayerImpl since it's 1. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Stop using contents_scale_x() in PictureLayerImpl since it's 1. We are still passing it around and scaling a rect by it but it is always 1 so just make that explicit. R=vmpstr Committed: https://crrev.com/f502e86b9352ab1cffff5c76ff9d5e33c8e6dcbc Cr-Commit-Position: refs/heads/master@{#294730}

Patch Set 1 #

Patch Set 2 : contentscale: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -23 lines) Patch
M cc/layers/picture_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 8 chunks +12 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danakj
6 years, 3 months ago (2014-09-12 21:54:41 UTC) #1
vmpstr
lgtm https://codereview.chromium.org/566023004/diff/20001/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/566023004/diff/20001/cc/layers/picture_layer_impl.cc#newcode527 cc/layers/picture_layer_impl.cc:527: visible_rect_in_content_space.Intersect(visible_content_rect()); This seems unrelated to removing contents_scale_x? I'm ...
6 years, 3 months ago (2014-09-12 22:34:21 UTC) #2
danakj
https://codereview.chromium.org/566023004/diff/20001/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/566023004/diff/20001/cc/layers/picture_layer_impl.cc#newcode527 cc/layers/picture_layer_impl.cc:527: visible_rect_in_content_space.Intersect(visible_content_rect()); On 2014/09/12 22:34:20, vmpstr wrote: > This seems ...
6 years, 3 months ago (2014-09-13 02:03:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/566023004/40001
6 years, 3 months ago (2014-09-13 03:11:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001) as cc53b4e6f5072cf8c57e2a13f1152dc6a1811229
6 years, 3 months ago (2014-09-13 04:27:30 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 04:29:21 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f502e86b9352ab1cffff5c76ff9d5e33c8e6dcbc
Cr-Commit-Position: refs/heads/master@{#294730}

Powered by Google App Engine
This is Rietveld 408576698