Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 566023003: Add "rt" to libs of GN build linux sandbox unittests. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add "rt" to libs of GN build linux sandbox unittests. This is causing a compile failure in component mode. TBR=dpranke Committed: https://crrev.com/e3934435b6ad1e97910e532e490b8d672d34ffba Cr-Commit-Position: refs/heads/master@{#294658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M sandbox/linux/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
6 years, 3 months ago (2014-09-12 21:07:19 UTC) #2
Dirk Pranke
lgtm
6 years, 3 months ago (2014-09-12 21:09:18 UTC) #3
brettw
Committed patchset #1 (id:1) to pending queue manually as c03e515 (presubmit successful).
6 years, 3 months ago (2014-09-12 21:15:13 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 21:20:53 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3934435b6ad1e97910e532e490b8d672d34ffba
Cr-Commit-Position: refs/heads/master@{#294658}

Powered by Google App Engine
This is Rietveld 408576698