Issue 565973006: Issue 19800. Support for inlining getters/setters.

Issue 565973006: Issue 19800. Support for inlining getters/setters. (Closed)

Created:
6 years, 3 months ago by scheglov

Modified:
6 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 19800. Support for inlining getters/setters. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=19800 Committed: https://code.google.com/p/dart/source/detail?r=40230

Patch Set 1 #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+171 lines, -47 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/InlineMethodAction_NEW.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/inline_method.dart	View	5 chunks	+45 lines, -36 lines	2 comments	Download
M	pkg/analysis_server/test/services/refactoring/inline_method_test.dart	View	8 chunks	+124 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/565973006/diff/1/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart File pkg/analysis_server/lib/src/services/refactoring/inline_method.dart (right): https://codereview.chromium.org/565973006/diff/1/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart#newcode590 pkg/analysis_server/lib/src/services/refactoring/inline_method.dart:590: assignment = nodeParent.parent; Are two levels always enough? ...

6 years, 3 months ago (2014-09-12 22:42:31 UTC) #2

scheglov

https://codereview.chromium.org/565973006/diff/1/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart File pkg/analysis_server/lib/src/services/refactoring/inline_method.dart (right): https://codereview.chromium.org/565973006/diff/1/pkg/analysis_server/lib/src/services/refactoring/inline_method.dart#newcode590 pkg/analysis_server/lib/src/services/refactoring/inline_method.dart:590: assignment = nodeParent.parent; On 2014/09/12 22:42:31, Brian Wilkerson wrote: ...

6 years, 3 months ago (2014-09-14 03:17:39 UTC) #3

scheglov

6 years, 3 months ago (2014-09-14 03:18:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40230 (presubmit successful).

Expand Messages | Collapse Messages