Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: scripts/slave/unittests/results_dashboard_test.py

Issue 565973005: Revert of Update buildbots to parse new telemetry JSON format. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/telemetry_utils.py ('k') | scripts/slave/unittests/runtest_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/unittests/results_dashboard_test.py
diff --git a/scripts/slave/unittests/results_dashboard_test.py b/scripts/slave/unittests/results_dashboard_test.py
index 6f50e6350aed2fe11cdbd6c847a3af9da2b6d3e7..9e5c78512230e6469c126f43000e20490ec03ed5 100755
--- a/scripts/slave/unittests/results_dashboard_test.py
+++ b/scripts/slave/unittests/results_dashboard_test.py
@@ -38,32 +38,6 @@
def tearDown(self):
self.mox.UnsetStubs()
-
- def test_MakeDashboardJsonV1(self):
- self.mox.StubOutWithMock(slave_utils, 'GetActiveMaster')
- slave_utils.GetActiveMaster().AndReturn('ChromiumPerf')
- self.mox.StubOutWithMock(results_dashboard, '_GetTimestamp')
- # pylint: disable=W0212
- results_dashboard._GetTimestamp().AndReturn(12345)
- results_dashboard._GetTimestamp().AndReturn(12345)
- self.mox.ReplayAll()
- v1json = results_dashboard.MakeDashboardJsonV1(
- {'some_json': 'from_telemetry'},
- {'rev': 'f46bf3c', 'git_revision': 'f46bf3c', 'v8_rev': '73a34f'},
- 'win7', 'chromium.perf', 'Windows Builder (1)', '432', {'x': 'y'},
- True)
- self.assertEqual({
- 'master': 'ChromiumPerf',
- 'masterid': 'chromium.perf',
- 'bot': 'win7',
- 'buildername': 'Windows Builder (1)',
- 'buildnumber': '432',
- 'chart_data': {'some_json': 'from_telemetry'},
- 'is_ref': True,
- 'point_id': 12345,
- 'supplemental': {'default_rev': 'r_chromium', 'x': 'y'},
- 'versions': {'v8_rev': '73a34f', 'chromium': 'f46bf3c'}},
- v1json)
def test_MakeListOfPoints_MinimalCase(self):
"""A very simple test of a call to MakeListOfPoints."""
@@ -331,38 +305,28 @@
"""After failing once, the same JSON is sent the next time."""
# First, some data is sent but it fails for some reason.
self._TestSendResults(
- {'sample': 1, 'master': 'm', 'bot': 'b',
- 'chart_data': {'benchmark_name': 'b'}, 'point_id': 1234},
- [('{"sample": 1, "master": "m", "bot": "b", '
- '"chart_data": {"benchmark_name": "b"}, "point_id": 1234}')],
+ {'sample': 1},
+ ['{"sample": 1}'],
[urllib2.URLError('some reason')])
# The next time, the old data is sent with the new data.
self._TestSendResults(
- {'sample': 2, 'master': 'm2', 'bot': 'b2',
- 'chart_data': {'benchmark_name': 'b'}, 'point_id': 1234},
- [('{"sample": 1, "master": "m", "bot": "b", '
- '"chart_data": {"benchmark_name": "b"}, "point_id": 1234}'),
- ('{"sample": 2, "master": "m2", "bot": "b2", '
- '"chart_data": {"benchmark_name": "b"}, "point_id": 1234}')],
+ {'sample': 2},
+ ['{"sample": 1}', '{"sample": 2}'],
[None, None])
def test_SuccessNotRetried(self):
"""After being successfully sent, data is not re-sent."""
# First, some data is sent.
self._TestSendResults(
- {'sample': 1, 'master': 'm', 'bot': 'b',
- 'chart_data': {'benchmark_name': 'b'}, 'point_id': 1234},
- [('{"sample": 1, "master": "m", "bot": "b", '
- '"chart_data": {"benchmark_name": "b"}, "point_id": 1234}')],
+ {'sample': 1},
+ ['{"sample": 1}'],
[None])
# The next time, the old data is not sent with the new data.
self._TestSendResults(
- {'sample': 2, 'master': 'm2', 'bot': 'b2',
- 'chart_data': {'benchmark_name': 'b'}, 'point_id': 1234},
- [('{"sample": 2, "master": "m2", "bot": "b2", '
- '"chart_data": {"benchmark_name": "b"}, "point_id": 1234}')],
+ {'sample': 2},
+ ['{"sample": 2}'],
[None])
« no previous file with comments | « scripts/slave/telemetry_utils.py ('k') | scripts/slave/unittests/runtest_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698