Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Side by Side Diff: scripts/slave/unittests/telemetry_test.py

Issue 565973005: Revert of Update buildbots to parse new telemetry JSON format. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « scripts/slave/unittests/runtest_test.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Unit tests for telemetry.py. 6 """Unit tests for telemetry.py.
7 7
8 This is a basic check that telemetry.py forms commands properly. 8 This is a basic check that telemetry.py forms commands properly.
9 9
10 """ 10 """
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 def setUp(self): 48 def setUp(self):
49 super(TelemetryTest, self).setUp() 49 super(TelemetryTest, self).setUp()
50 50
51 self.telemetry = os.path.join(SCRIPT_DIR, '..', 'telemetry.py') 51 self.telemetry = os.path.join(SCRIPT_DIR, '..', 'telemetry.py')
52 self.capture = chromium_utils.FilterCapture() 52 self.capture = chromium_utils.FilterCapture()
53 53
54 def testSimpleCommand(self): 54 def testSimpleCommand(self):
55 fp = self._GetDefaultFactoryProperties() 55 fp = self._GetDefaultFactoryProperties()
56 56
57 cmd = [self.telemetry, '--print-cmd', 57 cmd = [self.telemetry, '--print-cmd',
58 '--factory-properties=%s' % json.dumps(fp), 58 '--factory-properties=%s' % json.dumps(fp)]
59 '--chart-output-filename=name.out']
60 59
61 ret = runScript(cmd, filter_obj=self.capture, print_cmd=False) 60 ret = runScript(cmd, filter_obj=self.capture, print_cmd=False)
62 self.assertEqual(ret, 0) 61 self.assertEqual(ret, 0)
63 62
64 runtest = os.path.abspath(os.path.join(SCRIPT_DIR, '..', 'runtest.py')) 63 runtest = os.path.abspath(os.path.join(SCRIPT_DIR, '..', 'runtest.py'))
65 64
66 expectedText = ([ 65 expectedText = ([
67 '\'%s\' ' % sys.executable + 66 '\'%s\' ' % sys.executable +
68 '\'%s\' \'--run-python-script\' \'--target\' \'Release\' ' % runtest + 67 '\'%s\' \'--run-python-script\' \'--target\' \'Release\' ' % runtest +
69 '\'--no-xvfb\' ' + 68 '\'--no-xvfb\' ' +
70 '\'--factory-properties=' + 69 '\'--factory-properties=' +
71 '{"target": "Release", ' + 70 '{"target": "Release", ' +
72 '"build_dir": "src/out", "perf_id": "android-gn", ' + 71 '"build_dir": "src/out", "perf_id": "android-gn", ' +
73 '"step_name": "sunspider", "test_name": "sunspider", ' + 72 '"step_name": "sunspider", "test_name": "sunspider", ' +
74 '"target_platform": "linux2", "target_os": "android", ' + 73 '"target_platform": "linux2", "target_os": "android", ' +
75 '"show_perf_results": true}\' ' + 74 '"show_perf_results": true}\' ' +
76 '\'src/build/android/test_runner.py\' \'perf\' \'-v\' ' + 75 '\'src/build/android/test_runner.py\' \'perf\' \'-v\' ' +
77 '\'--release\' ' + 76 '\'--release\' ' +
78 '\'--single-step\' ' + 77 '\'--single-step\' ' +
79 '\'--\' ' + 78 '\'--\' ' +
80 '\'src/tools/perf/run_benchmark\' \'-v\' ' + 79 '\'src/tools/perf/run_benchmark\' \'-v\' ' +
81 '\'--output-format=chartjson\' ' + 80 '\'--output-format=buildbot\' ' +
82 '\'--browser=android-chrome-shell\' \'sunspider\' ' + 81 '\'--browser=android-chrome-shell\' \'sunspider\''
83 '\'--output=name.out\''
84 ]) 82 ])
85 83
86 self.assertEqual(expectedText, self.capture.text) 84 self.assertEqual(expectedText, self.capture.text)
87 85
88 def testExtraArg(self): 86 def testExtraArg(self):
89 fp = self._GetDefaultFactoryProperties() 87 fp = self._GetDefaultFactoryProperties()
90 fp['extra_args'] = ['--profile-dir=fake_dir'] 88 fp['extra_args'] = ['--profile-dir=fake_dir']
91 89
92 cmd = [self.telemetry, '--print-cmd', 90 cmd = [self.telemetry, '--print-cmd',
93 '--factory-properties=%s' % json.dumps(fp), 91 '--factory-properties=%s' % json.dumps(fp)]
94 '--chart-output-filename=tmpfile']
95 92
96 ret = runScript(cmd, filter_obj=self.capture, print_cmd=False) 93 ret = runScript(cmd, filter_obj=self.capture, print_cmd=False)
97 self.assertEqual(ret, 0) 94 self.assertEqual(ret, 0)
98 95
99 runtest = os.path.abspath(os.path.join(SCRIPT_DIR, '..', 'runtest.py')) 96 runtest = os.path.abspath(os.path.join(SCRIPT_DIR, '..', 'runtest.py'))
100 97
101 expectedText = ([ 98 expectedText = ([
102 '\'%s\' ' % sys.executable + 99 '\'%s\' ' % sys.executable +
103 '\'%s\' \'--run-python-script\' \'--target\' \'Release\' ' % runtest + 100 '\'%s\' \'--run-python-script\' \'--target\' \'Release\' ' % runtest +
104 '\'--no-xvfb\' ' + 101 '\'--no-xvfb\' ' +
105 '\'--factory-properties=' + 102 '\'--factory-properties=' +
106 '{"target": "Release", "build_dir": "src/out", ' + 103 '{"target": "Release", "build_dir": "src/out", ' +
107 '"extra_args": ["--profile-dir=fake_dir"], ' + 104 '"extra_args": ["--profile-dir=fake_dir"], ' +
108 '"perf_id": "android-gn", ' + 105 '"perf_id": "android-gn", ' +
109 '"step_name": "sunspider", "test_name": "sunspider", ' + 106 '"step_name": "sunspider", "test_name": "sunspider", ' +
110 '"target_platform": "linux2", "target_os": "android", ' + 107 '"target_platform": "linux2", "target_os": "android", ' +
111 '"show_perf_results": true}\' ' + 108 '"show_perf_results": true}\' ' +
112 '\'src/build/android/test_runner.py\' \'perf\' \'-v\' ' + 109 '\'src/build/android/test_runner.py\' \'perf\' \'-v\' ' +
113 '\'--release\' ' + 110 '\'--release\' ' +
114 '\'--single-step\' ' + 111 '\'--single-step\' ' +
115 '\'--\' ' + 112 '\'--\' ' +
116 '\'src/tools/perf/run_benchmark\' \'-v\' ' + 113 '\'src/tools/perf/run_benchmark\' \'-v\' ' +
117 '\'--output-format=chartjson\' ' + 114 '\'--output-format=buildbot\' ' +
118 '\'--profile-dir=fake_dir\' '+ 115 '\'--profile-dir=fake_dir\' '+
119 '\'--browser=android-chrome-shell\' \'sunspider\' ' + 116 '\'--browser=android-chrome-shell\' \'sunspider\''
120 '\'--output=tmpfile\''
121 ]) 117 ])
122 118
123 self.assertEqual(expectedText, self.capture.text) 119 self.assertEqual(expectedText, self.capture.text)
124 120
125 if __name__ == '__main__': 121 if __name__ == '__main__':
126 unittest.main() 122 unittest.main()
OLDNEW
« no previous file with comments | « scripts/slave/unittests/runtest_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698