Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 565973003: Fix Flush in DemuxerStreamAdapter. (Closed)

Created:
6 years, 3 months ago by damienv1
Modified:
6 years, 3 months ago
Reviewers:
lcwu1, gunsch
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Flush in DemuxerStreamAdapter. When the DemuxerStream has a pending read, this one must be completed before invoking the flush callback. BUG=408189 Committed: https://crrev.com/385df0994e1e8f7e802275f063ae68fae46ca718 Cr-Commit-Position: refs/heads/master@{#294669}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Additional DCHECK in Read. #

Patch Set 4 : Unit test update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -25 lines) Patch
M chromecast/media/cma/filters/demuxer_stream_adapter.h View 2 chunks +10 lines, -2 lines 0 comments Download
M chromecast/media/cma/filters/demuxer_stream_adapter.cc View 1 2 7 chunks +37 lines, -12 lines 0 comments Download
M chromecast/media/cma/filters/demuxer_stream_adapter_unittest.cc View 1 2 3 11 chunks +36 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
lcwu1
lgtm
6 years, 3 months ago (2014-09-12 16:53:59 UTC) #2
gunsch
On 2014/09/12 16:53:59, lcwu1 wrote: > lgtm Any chance of a test to catch this?
6 years, 3 months ago (2014-09-12 17:12:34 UTC) #3
damienv1
PTAL
6 years, 3 months ago (2014-09-12 20:35:08 UTC) #4
gunsch
On 2014/09/12 20:35:08, damienv1 wrote: > PTAL lgtm
6 years, 3 months ago (2014-09-12 21:03:05 UTC) #7
lcwu1
lgtm
6 years, 3 months ago (2014-09-12 21:13:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565973003/60001
6 years, 3 months ago (2014-09-12 21:24:10 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 614562c2697ee2336bfa4f8694ab030250ca5eb5
6 years, 3 months ago (2014-09-12 21:53:17 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 21:56:36 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/385df0994e1e8f7e802275f063ae68fae46ca718
Cr-Commit-Position: refs/heads/master@{#294669}

Powered by Google App Engine
This is Rietveld 408576698