Credential Manager: Introduce a MockCredentialManagerClient.

Credential Manager: Introduce a MockCredentialManagerClient.

Since we create the WebCredentialManagerClient in //chrome, we need a
tiny mock to ensure that the Blink-side has something it can wire
itself up to. This is that thing.

BUG=400674
Committed: https://crrev.com/41667ab15bb40d84459acf3139f19178bed48778
Cr-Commit-Position: refs/heads/master@{#295022}

[Mike West, 2014-09-12 13:56:10]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2014-09-12 13:56:10]

Mind taking a look at this tiny mock, Jochen?

-mike

[jochen (gone - plz use gerrit), 2014-09-12 14:16:26]

lgtm with nits

https://codereview.chromium.org/565943002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_credential_manager_client.h
(right):

https://codereview.chromium.org/565943002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_credential_manager_client.h:25: void
SetResponse(blink::WebCredential*);
nit. add parameters names (chromium style)

https://codereview.chromium.org/565943002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_credential_manager_client.h:28: virtual
void dispatchFailedSignIn(const blink::WebCredential& credential,
no override on blink API implementations

[Mike West, 2014-09-12 14:26:00]

Thanks!

However, I forgot to wire up the 'SetResponse' method to the TestRunner
JavaScript interface. :/ Would you mind taking another look to ensure I didn't
screw that up?

[Mike West, 2014-09-16 06:27:09]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-09-16 06:28:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565943002/40001

[commit-bot: I haz the power, 2014-09-16 06:53:40]

Committed patchset #3 (id:40001) as 2d48351ec543e361f51f14e4f1ecacc3a34345f8

[commit-bot: I haz the power, 2014-09-16 06:55:11]

Patchset 3 (id:??) landed as
https://crrev.com/41667ab15bb40d84459acf3139f19178bed48778
Cr-Commit-Position: refs/heads/master@{#295022}