Sort ServiceWorkerCacheStorage::Keys() by creation order.

Sort ServiceWorkerCacheStorage::Keys() in creation order.

Keeps a vector of cache names in creation order.  They're written to and read from the the index file in the same order.

This simplifies the keys unit tests as the order of the vectors is always the same and they can now be compared directly.

BUG=408787
Committed: https://chromium.googlesource.com/chromium/src/+/adc3bcac9a00eb7709dd279cf54751a025a3abf6

[jkarlin, 2014-09-12 14:15:49]

jkarlin@chromium.org changed reviewers:
+ michaeln@chromium.org

[jkarlin, 2014-09-12 14:15:50]

Thanks!

[michaeln, 2014-09-12 21:45:32]

lgtm

https://codereview.chromium.org/565913002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_cache_storage.cc (right):

https://codereview.chromium.org/565913002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage.cc:211: virtual void
WriteIndex(const ServiceWorkerCacheStorage::Strings& cache_names,
is the fully qualification needed given that CacheLoaders are nested classes?

https://codereview.chromium.org/565913002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_cache_storage.h (right):

https://codereview.chromium.org/565913002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage.h:45: typedef
std::vector<std::string> Strings;
maybe call this StringVector, i was wondering what sort of collection it was
when reading .cc code

[jkarlin, 2014-09-15 14:14:30]

https://codereview.chromium.org/565913002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_cache_storage.cc (right):

https://codereview.chromium.org/565913002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage.cc:211: virtual void
WriteIndex(const ServiceWorkerCacheStorage::Strings& cache_names,
On 2014/09/12 21:45:32, michaeln wrote:
> is the fully qualification needed given that CacheLoaders are nested classes?

Done.

https://codereview.chromium.org/565913002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_cache_storage.h (right):

https://codereview.chromium.org/565913002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_cache_storage.h:45: typedef
std::vector<std::string> Strings;
On 2014/09/12 21:45:32, michaeln wrote:
> maybe call this StringVector, i was wondering what sort of collection it was
> when reading .cc code

Done.

[jkarlin, 2014-09-15 15:34:36]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-09-15 15:37:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565913002/40001

[commit-bot: I haz the power, 2014-09-15 17:01:09]

Patchset 3 (id:??) landed as
https://crrev.com/9fffc1594734dfc292ec558b96d9ceb08ff08671
Cr-Commit-Position: refs/heads/master@{#294838}

[commit-bot: I haz the power, 2014-09-15 17:02:21]

Committed patchset #3 (id:40001) as adc3bcac9a00eb7709dd279cf54751a025a3abf6