Fixed "Relaunch and Powerwash" button on a chrome://help page.

Fixed "Relaunch and Powerwash" button on a chrome://help page.

UI state of the elements related to channel switcher should depend only on update status, current and target channels, not on the internal state which is reset each time chrome://help is reloaded.

BUG=323530
TEST=manual tests on a falco device

Committed: https://crrev.com/e464c704867a64713c1ca17e458b9873d84a2483
Cr-Commit-Position: refs/heads/master@{#295056}

[ygorshenin1, 2014-09-12 13:44:40]

ygorshenin@chromium.org changed reviewers:
+ stevenjb@chromium.org, xiyuan@chromium.org

[ygorshenin1, 2014-09-12 13:44:41]

+ xiyuan@ for chrome/browser/resources/*
+ stevenjb@ for chromeos/dbus/*

[xiyuan, 2014-09-12 14:47:58]

lgtm

[stevenjb, 2014-09-12 16:24:10]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2014-09-12 16:24:10]

+michaelpg@ who has been lookat at this UI.
chromeos/ owner lgtm

[michaelpg, 2014-09-15 19:05:52]

lgtm with a question

https://codereview.chromium.org/565903002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/help/channel_change_page.js (left):

https://codereview.chromium.org/565903002/diff/20001/chrome/browser/resources...
chrome/browser/resources/help/channel_change_page.js:198:
help.HelpPage.updateChannelChangePageContainerVisibility();
Is this call replaced anywhere?

this works because we call updateIsEnterpriseManaged before we call
update[Current|Target]Channel, but it's not clear that this page should be
dependent on that ordering.

[ygorshenin1, 2014-09-16 12:49:48]

Many thanks!

https://codereview.chromium.org/565903002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/help/channel_change_page.js (left):

https://codereview.chromium.org/565903002/diff/20001/chrome/browser/resources...
chrome/browser/resources/help/channel_change_page.js:198:
help.HelpPage.updateChannelChangePageContainerVisibility();
Thanks for pointing this out! I've added HelpPage.updateIsEnterpriseManaged()
which implicitly calls updateChannelChangePageContainerVisibility() (as it was
done for setTargetChannel() and setCurrentChannel()).

On 2014/09/15 19:05:52, michaelpg wrote:
> Is this call replaced anywhere?
> 
> this works because we call updateIsEnterpriseManaged before we call
> update[Current|Target]Channel, but it's not clear that this page should be
> dependent on that ordering.

[ygorshenin1, 2014-09-16 12:50:38]

The CQ bit was checked by ygorshenin@chromium.org

[commit-bot: I haz the power, 2014-09-16 12:51:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/565903002/40001

[commit-bot: I haz the power, 2014-09-16 13:48:03]

Committed patchset #3 (id:40001) as 35df67fddcf17247c2ff0496c70070c325d8844f

[commit-bot: I haz the power, 2014-09-16 13:51:46]

Patchset 3 (id:??) landed as
https://crrev.com/e464c704867a64713c1ca17e458b9873d84a2483
Cr-Commit-Position: refs/heads/master@{#295056}