Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 565883002: android: Don't emit useless info into generated makefiles. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

android: Don't emit useless info into generated makefiles. To make the generated makefiles smaller and slightly easier to debug, omit information that is useless: * Don't emit LDFLAGS for static libraries as the linker is not invoked. * For static libraries, only include system libraries in the lists of libraries to link against. The system libraries are required in case they provide implicit include paths, but there's no need to include the large list of gyp-generated targets. * Don't emit empty lists of libraries to link against. * Don't bother setting LOCAL_MODULE_TAGS to optional as that's the default value. Also, stop attempting to remove standard system include paths; the list is out of date, never matches anything in the Chromium build, and it doesn't really matter if a standard path is duplicated anyway. BUG= R=primiano@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -51 lines) Patch
M pylib/gyp/generator/android.py View 5 chunks +31 lines, -51 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Torne
This passes all the gyp-android tests locally and I can still build libwebviewchromium with this ...
6 years, 3 months ago (2014-09-12 12:59:14 UTC) #2
Primiano Tucci (use gerrit)
lgtm
6 years, 3 months ago (2014-09-12 14:02:23 UTC) #3
Torne
6 years, 3 months ago (2014-09-12 14:59:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 1976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698