Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 565873002: Removing ic.h from code-stubs.h (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Yang, Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Removing ic.h from code-stubs.h CodeStubs use state types defined in ic.h, but this has the unfortunate effect of spreading ic.h all over the place. Instead, define these shared state types in ic-public.h and allow ic.h to concern itself with internal state change of the ICs. More work could/should be done here, but this is a first step. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23977

Patch Set 1 : Rebased. #

Patch Set 2 : Adjustments. #

Patch Set 3 : Done with ia32. #

Patch Set 4 : Pre-review. #

Patch Set 5 : Ports. #

Patch Set 6 : Moved CompareICState::ComputeCondition() back to CompareIC. #

Patch Set 7 : Comment response. #

Patch Set 8 : REBASE and mips. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1154 lines, -1033 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 13 chunks +20 lines, -16 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 14 chunks +20 lines, -16 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 2 3 4 5 6 20 chunks +44 lines, -37 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 5 8 chunks +29 lines, -23 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/disassembler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 3 chunks +8 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 13 chunks +21 lines, -19 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/handler-compiler.h View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ic.h View 1 2 3 4 5 6 7 chunks +8 lines, -217 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 11 chunks +30 lines, -616 lines 0 comments Download
M src/ic/ic-inl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A src/ic/ic-state.h View 1 2 3 4 5 6 1 chunk +238 lines, -0 lines 0 comments Download
A src/ic/ic-state.cc View 1 2 3 4 5 6 1 chunk +614 lines, -0 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/mips/ic-compiler-mips.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 5 6 7 13 chunks +20 lines, -16 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -3 lines 0 comments Download
M src/type-info.cc View 1 2 5 chunks +8 lines, -7 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 13 chunks +21 lines, -19 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mvstanton
Hi guys, whoever gets a chance to look first :p... Thanks, --Michael
6 years, 3 months ago (2014-09-12 09:31:47 UTC) #5
mvstanton
Hi guys, Ports done, and I moved CompareICState::ComputeCondition() back to CompareIC where it is fine. ...
6 years, 3 months ago (2014-09-12 10:16:43 UTC) #6
Yang
LGTM aside from what we talked about (ic-state instead of ic-public, and derive ICUtility from ...
6 years, 3 months ago (2014-09-15 14:57:32 UTC) #7
mvstanton
6 years, 3 months ago (2014-09-16 12:52:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #8 (id:200001) manually as 23977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698