Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 565833002: Refactoring the weak_ptr_factory order in src/content/common (Closed)

Created:
6 years, 3 months ago by MRV
Modified:
6 years, 3 months ago
Reviewers:
jam, piman
CC:
lgombos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactoring the weak_ptr_factory order in src/content/common Changing in the intialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/ef20600e0dd7b45483a8e5264df36304a8ecef5d Cr-Commit-Position: refs/heads/master@{#294551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
jam@chromium.org: Please review changes in src/ontent/common folder piman@chromium.org: Please review changes in src/ontent/common folder
6 years, 3 months ago (2014-09-12 05:17:48 UTC) #2
piman
lgtm
6 years, 3 months ago (2014-09-12 05:33:43 UTC) #3
MRV
On 2014/09/12 05:33:43, piman (Very slow to review) wrote: > lgtm Thanks you Mr. piman ...
6 years, 3 months ago (2014-09-12 05:35:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565833002/1
6 years, 3 months ago (2014-09-12 05:36:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 77a92d54d5a24eb1c6934f7872dce2996674b687
6 years, 3 months ago (2014-09-12 06:42:45 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 06:44:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef20600e0dd7b45483a8e5264df36304a8ecef5d
Cr-Commit-Position: refs/heads/master@{#294551}

Powered by Google App Engine
This is Rietveld 408576698