Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 565803006: Revert of Cleanup: Remove base/file_util.h. Convert remaining references. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Cleanup: Remove base/file_util.h. Convert remaining references. (patchset #1 id:1 of https://codereview.chromium.org/568873004/) Reason for revert: Broke some internal builds. Need to give them a chance to fix their builds. Original issue's description: > Cleanup: Remove base/file_util.h. Convert remaining references. > > TBR=brettw@chromium.org > > Committed: https://crrev.com/6d63c4898c2da5a286d01f80229baeb914f99f18 > Cr-Commit-Position: refs/heads/master@{#294729} TBR=brettw@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/cdf83e8f7ec3d723c058260a492c2d9f83ec4a25 Cr-Commit-Position: refs/heads/master@{#294755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M android_webview/browser/renderer_host/print_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/cookie_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A base/file_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of Cleanup: Remove base/file_util.h. Convert remaining references.
6 years, 3 months ago (2014-09-13 20:58:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565803006/1
6 years, 3 months ago (2014-09-13 20:59:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d6ec632a254e9837b5d8c4dd780dfe779da05213
6 years, 3 months ago (2014-09-13 21:02:13 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 21:04:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cdf83e8f7ec3d723c058260a492c2d9f83ec4a25
Cr-Commit-Position: refs/heads/master@{#294755}

Powered by Google App Engine
This is Rietveld 408576698