Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 565803005: use SkData::NewUninitialized (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : readInData -> NewFromStream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -78 lines) Patch
M include/core/SkData.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/core/SkData.cpp View 1 2 chunks +12 lines, -0 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 2 chunks +8 lines, -9 lines 0 comments Download
M src/core/SkStream.cpp View 1 2 chunks +2 lines, -10 lines 0 comments Download
M src/images/SkDecodingImageGenerator.cpp View 1 1 chunk +3 lines, -5 lines 0 comments Download
M tests/MallocPixelRefTest.cpp View 3 chunks +5 lines, -12 lines 0 comments Download
M tests/SurfaceTest.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M tools/lua/lua_app.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
M tools/lua/lua_pictures.cpp View 1 2 chunks +4 lines, -12 lines 0 comments Download
M tools/skdiff_utils.cpp View 1 chunk +3 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reed1
cloned from https://codereview.chromium.org/568683002/
6 years, 3 months ago (2014-09-12 18:45:56 UTC) #2
reed1
ptal
6 years, 3 months ago (2014-09-12 18:56:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565803005/20001
6 years, 3 months ago (2014-09-12 18:56:44 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-12 18:56:45 UTC) #6
bungeman-skia
lgtm
6 years, 3 months ago (2014-09-12 19:09:28 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:12:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 9594da111dc1c36c1912eb61207aaa54c17ea550

Powered by Google App Engine
This is Rietveld 408576698