Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 565803004: mac: Use immersive fullscreen for html5 style fullscreen. (Closed)

Created:
6 years, 3 months ago by erikchen
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Use immersive fullscreen for html5 style fullscreen. This accidentally changed during the large fullscreen refactor. The method enterPresentationModeForURL:* was previously used to enter both immersive fullscreen and AppKit Fullscreen. Now it is only used to enter AppKit Fullscreen. BUG=406656 Committed: https://crrev.com/802fbf73dba0b4f09f96640452d49de768c43cc0 Cr-Commit-Position: refs/heads/master@{#294636}

Patch Set 1 #

Patch Set 2 : Comments from rsesek. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
erikchen
rsesek: Please review.
6 years, 3 months ago (2014-09-12 17:40:24 UTC) #2
Robert Sesek
I think the comment in the .h needs to be updated, too.
6 years, 3 months ago (2014-09-12 17:42:39 UTC) #3
erikchen
quite observant, sir. Fixed.
6 years, 3 months ago (2014-09-12 17:51:00 UTC) #4
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-12 17:51:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565803004/20001
6 years, 3 months ago (2014-09-12 18:19:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 95335dc65c534453f6c1373b5ff41e8314dfb756
6 years, 3 months ago (2014-09-12 19:43:24 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:47:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/802fbf73dba0b4f09f96640452d49de768c43cc0
Cr-Commit-Position: refs/heads/master@{#294636}

Powered by Google App Engine
This is Rietveld 408576698