Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 565793003: [Invalidation Tracking] Add trace events for compositor based invalidations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: squashed -> squashing Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/compositing/RenderLayerCompositor.cpp
diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.cpp b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
index 7355ed42f989715ca6c3e2965b591e988ef09d2d..b03490f2cc400aedd07534a5d12e2aba1fa29d2a 100644
--- a/Source/core/rendering/compositing/RenderLayerCompositor.cpp
+++ b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
@@ -35,6 +35,7 @@
#include "core/html/HTMLIFrameElement.h"
#include "core/inspector/InspectorInstrumentation.h"
#include "core/inspector/InspectorNodeIds.h"
+#include "core/inspector/InspectorTraceEvents.h"
#include "core/page/Chrome.h"
#include "core/page/ChromeClient.h"
#include "core/page/Page.h"
@@ -311,7 +312,7 @@ void RenderLayerCompositor::updateIfNeeded()
RenderLayer* updateRoot = rootRenderLayer();
- Vector<RenderLayer*> layersNeedingPaintInvalidation;
+ LayersNeedingPaintInvalidation layersNeedingPaintInvalidation;
if (updateType >= CompositingUpdateAfterCompositingInputChange) {
CompositingInputsUpdater(updateRoot).update();
@@ -377,7 +378,12 @@ void RenderLayerCompositor::updateIfNeeded()
}
for (unsigned i = 0; i < layersNeedingPaintInvalidation.size(); i++) {
- RenderLayer* layer = layersNeedingPaintInvalidation[i];
+ RenderLayer* layer = layersNeedingPaintInvalidation[i].first;
+ TRACE_EVENT_INSTANT1(
+ TRACE_DISABLED_BY_DEFAULT("devtools.timeline.invalidationTracking"),
+ "LayerInvalidationTracking",
+ "data",
+ InspectorLayerInvalidationTrackingEvent::data(layer->renderer()->containerForPaintInvalidation(), layersNeedingPaintInvalidation[i].second));
layer->paintInvalidator().computePaintInvalidationRectsIncludingNonCompositingDescendants();
paintInvalidationOnCompositingChange(layer);

Powered by Google App Engine
This is Rietveld 408576698