Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 565773003: MergeNetworkList can't group address under the same interface (Closed)

Created:
6 years, 3 months ago by guoweis_left_chromium
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

IpcNetworkManager in renderer/p2p didn't specify the right network prefix, which prevent grouping mechanism in MergeNetworkList from working. The end result is that each Network after MergeNetworkList contains only 1 ip address. With this change, the grouping will happen correctly. WebRTC has logic to only retrieve single IP from each network for connectivity check already. This CL is a dup of https://codereview.chromium.org/536133003/ which was created under the wrong identity. BUG= Committed: https://crrev.com/bb4f3cc4fce55e68f3a4a63e541bc7ec62175aa4 Cr-Commit-Position: refs/heads/master@{#294912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -30 lines) Patch
M content/common/p2p_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.cc View 5 chunks +21 lines, -13 lines 0 comments Download
A content/renderer/p2p/ipc_network_manager_unittest.cc View 1 chunk +112 lines, -0 lines 0 comments Download
A content/renderer/p2p/network_list_manager.h View 1 chunk +38 lines, -0 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.h View 2 chunks +8 lines, -10 lines 0 comments Download
M net/base/net_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
guoweis2
Hi, I incorrectly used my webrtc account to create the previous CL and failed the ...
6 years, 3 months ago (2014-09-15 20:01:15 UTC) #2
Sergey Ulanov
lgtm
6 years, 3 months ago (2014-09-15 20:06:49 UTC) #3
Will Harris
On 2014/09/15 20:01:15, guoweis2 wrote: > Hi, > > I incorrectly used my webrtc account ...
6 years, 3 months ago (2014-09-15 20:07:54 UTC) #4
davidben
lgtm
6 years, 3 months ago (2014-09-15 20:34:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/565773003/1
6 years, 3 months ago (2014-09-15 20:37:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as b8c81d0b2cbd8f9d2e94cd68273eaae129a7dff7
6 years, 3 months ago (2014-09-15 23:07:31 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 23:16:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb4f3cc4fce55e68f3a4a63e541bc7ec62175aa4
Cr-Commit-Position: refs/heads/master@{#294912}

Powered by Google App Engine
This is Rietveld 408576698