Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Unified Diff: native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc

Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc
diff --git a/native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc b/native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc
index df2d99436a11c0138fd8808a98d0d16d18f5f72c..79446aee1396578a1a44c17d101cd18a124bbd9e 100644
--- a/native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc
+++ b/native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc
@@ -127,7 +127,7 @@ class KernelWrapTest : public ::testing::Test {
errno = 0;
// Initializing the KernelProxy opens stdin/stdout/stderr.
- EXPECT_CALL(mock, open(_, _))
+ EXPECT_CALL(mock, open(_, _, _))
.WillOnce(Return(0))
.WillOnce(Return(1))
.WillOnce(Return(2));
@@ -450,12 +450,12 @@ TEST_F(KernelWrapTest, munmap) {
TEST_F(KernelWrapTest, open) {
// We pass O_RDONLY because we do not want an error in flags translation
- EXPECT_CALL(mock, open(kDummyConstChar, 0))
+ EXPECT_CALL(mock, open(kDummyConstChar, 0, 0))
.WillOnce(Return(kDummyInt2))
.WillOnce(Return(kDummyInt2));
- EXPECT_EQ(kDummyInt2, open(kDummyConstChar, 0));
- EXPECT_EQ(kDummyInt2, open(kDummyConstChar, 0));
+ EXPECT_EQ(kDummyInt2, open(kDummyConstChar, 0, 0));
+ EXPECT_EQ(kDummyInt2, open(kDummyConstChar, 0, 0));
}
TEST_F(KernelWrapTest, pipe) {
« no previous file with comments | « native_client_sdk/src/tests/nacl_io_test/kernel_proxy_test.cc ('k') | native_client_sdk/src/tests/nacl_io_test/mock_fs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698