native_client_sdk/src/tests/nacl_io_test/jspipe_test.cc - Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tests/nacl_io_test/jspipe_test.cc

Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/tests/nacl_io_test/fuse_fs_test.cc ('k') | native_client_sdk/src/tests/nacl_io_test/kernel_object_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/tests/nacl_io_test/jspipe_test.cc

diff --git a/native_client_sdk/src/tests/nacl_io_test/jspipe_test.cc b/native_client_sdk/src/tests/nacl_io_test/jspipe_test.cc

index 788d2b54f63a79c93679c4e3e6ce7528975737e4..0a8e867e7211ad9e6eea641fea073faf82a99960 100644

--- a/native_client_sdk/src/tests/nacl_io_test/jspipe_test.cc

+++ b/native_client_sdk/src/tests/nacl_io_test/jspipe_test.cc

@@ -434,7 +434,7 @@ TEST_F(JSPipeTest, JSPipeSelect) {

fd_set writefds;

fd_set errorfds;

- int pipe_fd = ki_open("/dev/jspipe1", O_RDONLY);

+ int pipe_fd = ki_open("/dev/jspipe1", O_RDONLY, 0);

ASSERT_GT(pipe_fd, 0) << "jspipe1 open failed: " << errno;

FD_ZERO(&readfds);