Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: native_client_sdk/src/tests/nacl_io_test/event_test.cc

Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/tests/nacl_io_test/event_test.cc
diff --git a/native_client_sdk/src/tests/nacl_io_test/event_test.cc b/native_client_sdk/src/tests/nacl_io_test/event_test.cc
index b450f3c860a9473615052f2d0a0d1bf423bb8fba..8084df0732a7f45e2355ed9d645f29f09fae1871 100644
--- a/native_client_sdk/src/tests/nacl_io_test/event_test.cc
+++ b/native_client_sdk/src/tests/nacl_io_test/event_test.cc
@@ -273,8 +273,8 @@ TEST_F(SelectPollTest, PollMemPipe) {
int fds[2];
// Both FDs for regular files should be read/write but not exception.
- fds[0] = kp->open("/test.txt", O_CREAT | O_WRONLY);
- fds[1] = kp->open("/test.txt", O_RDONLY);
+ fds[0] = kp->open("/test.txt", O_CREAT | O_WRONLY, 0777);
+ fds[1] = kp->open("/test.txt", O_RDONLY, 0);
ASSERT_GT(fds[0], -1);
ASSERT_GT(fds[1], -1);
@@ -302,8 +302,8 @@ TEST_F(SelectPollTest, SelectMemPipe) {
int fds[2];
// Both FDs for regular files should be read/write but not exception.
- fds[0] = kp->open("/test.txt", O_CREAT | O_WRONLY);
- fds[1] = kp->open("/test.txt", O_RDONLY);
+ fds[0] = kp->open("/test.txt", O_CREAT | O_WRONLY, 0777);
+ fds[1] = kp->open("/test.txt", O_RDONLY, 0);
ASSERT_GT(fds[0], -1);
ASSERT_GT(fds[1], -1);
SetFDs(fds, 2);
@@ -344,8 +344,8 @@ TEST_F(SelectPollTest, SelectPartialFdset) {
int fds[2];
// Both FDs for regular files should be read/write but not exception.
- fds[0] = kp->open("/test.txt", O_CREAT | O_WRONLY);
- fds[1] = kp->open("/test.txt", O_RDONLY);
+ fds[0] = kp->open("/test.txt", O_CREAT | O_WRONLY, 0777);
+ fds[1] = kp->open("/test.txt", O_RDONLY, 0);
ASSERT_GT(fds[0], -1);
ASSERT_GT(fds[1], -1);
ASSERT_LT(fds[1], 8);
« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/stream/stream_fs.cc ('k') | native_client_sdk/src/tests/nacl_io_test/fuse_fs_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698