native_client_sdk/src/libraries/nacl_io/kernel_proxy.h - Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/kernel_proxy.h

Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/kernel_object.cc ('k') | native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/libraries/nacl_io/kernel_proxy.h

diff --git a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.h b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.h

index 046d92267a7d7abdd060250a326e0f94c1ff1b53..0cfdbff22fc3d833625c21d5d7b96244a821234c 100644

--- a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.h

+++ b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.h

@@ -67,7 +67,7 @@ class KernelProxy : protected KernelObject {

virtual int open_resource(const char* file);

// KernelHandle and FD allocation and manipulation functions.

- virtual int open(const char* path, int open_flags);

+ virtual int open(const char* path, int open_flags, mode_t mode);

virtual int close(int fd);

virtual int dup(int fd);

virtual int dup2(int fd, int newfd);