native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc - Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc

Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.h ('k') | native_client_sdk/src/libraries/nacl_io/httpfs/http_fs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc b/native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc

index 1cd8c3723b91e8a8c7a2f13a13288d24fa361b1a..c747733231042d864218a51db54c9536ba8172d9 100644

--- a/native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc

+++ b/native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc

@@ -29,7 +29,8 @@ int64_t strtoull(const char* nptr, char** endptr, int base) {

} // namespace

-Error Html5Fs::Open(const Path& path, int open_flags, ScopedNode* out_node) {

+Error Html5Fs::OpenWithMode(const Path& path, int open_flags, mode_t mode,

+ ScopedNode* out_node) {

out_node->reset(NULL);

Error error = BlockUntilFilesystemOpen();

if (error)