Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: native_client_sdk/src/tests/nacl_io_test/fuse_fs_test.cc

Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/tests/nacl_io_test/fuse_fs_test.cc
diff --git a/native_client_sdk/src/tests/nacl_io_test/fuse_fs_test.cc b/native_client_sdk/src/tests/nacl_io_test/fuse_fs_test.cc
index 962ca811921a7f60dbdc0529f17724f607c4cd51..a4ae9f024d73ec661af4ec7fd0780fd5db5ca861 100644
--- a/native_client_sdk/src/tests/nacl_io_test/fuse_fs_test.cc
+++ b/native_client_sdk/src/tests/nacl_io_test/fuse_fs_test.cc
@@ -341,14 +341,14 @@ void KernelProxyFuseTest::TearDown() {
TEST_F(KernelProxyFuseTest, Basic) {
// Write a file.
- int fd = ki_open("/hello", O_WRONLY | O_CREAT);
+ int fd = ki_open("/hello", O_WRONLY | O_CREAT, 0777);
ASSERT_GT(fd, -1);
ASSERT_EQ(sizeof(hello_world),
ki_write(fd, hello_world, sizeof(hello_world)));
EXPECT_EQ(0, ki_close(fd));
// Then read it back in.
- fd = ki_open("/hello", O_RDONLY);
+ fd = ki_open("/hello", O_RDONLY, 0777);
binji 2014/09/11 23:51:41 0 instead of 0777?
bradn 2014/09/12 06:17:03 Done.
ASSERT_GT(fd, -1);
char buffer[30];

Powered by Google App Engine
This is Rietveld 408576698