native_client_sdk/src/libraries/nacl_io/kernel_wrap_win.cc - Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/kernel_wrap_win.cc

Issue 565763002: Plumbing though mode parameter to open, since fusefs can make use of it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« native_client_sdk/src/libraries/nacl_io/kernel_wrap_bionic.cc ('K') | « native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc ('k') | native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.h » ('j') | native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/libraries/nacl_io/kernel_wrap_win.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/kernel_wrap_win.cc b/native_client_sdk/src/libraries/nacl_io/kernel_wrap_win.cc

index d6177881b1d881f4caca08b282798a43f6f841fb..18c903dba8c292f90f3e2dae6ba6400251cdc13e 100644

--- a/native_client_sdk/src/libraries/nacl_io/kernel_wrap_win.cc

+++ b/native_client_sdk/src/libraries/nacl_io/kernel_wrap_win.cc

@@ -129,9 +129,6 @@ int _mkdir(const char* path) {

}

int _open(const char* path, int oflag, ...) {

-#if 0

- // TODO(binji): ki_open should use the pmode parameter. When it does, this

- // will be necessary to add in.

va_list list;

int pmode = 0;

if (oflag & _O_CREAT) {

@@ -139,8 +136,7 @@ int _open(const char* path, int oflag, ...) {

pmode = va_arg(list, int);

va_end(list);

}

-#endif

- return ki_open(path, oflag);

+ return ki_open(path, oflag, (mode_t) pmode);

}

int _sopen(const char* path, int oflag, int shflag) {